Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MergedAt field to PullRequestLinks #3053

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Add MergedAt field to PullRequestLinks #3053

merged 2 commits into from
Jan 19, 2024

Conversation

tatsuhiro-t
Copy link
Contributor

Fixes #3052

gmlewis
gmlewis requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at step 4 in CONTRIBUTING.md and run the required scripts then push (not force-push) the changed files to this PR. Thanks!

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9231a0f) 97.71% compared to head (9f177b9) 97.69%.
Report is 2 commits behind head on master.

Files Patch % Lines
github/code-scanning.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
- Coverage   97.71%   97.69%   -0.03%     
==========================================
  Files         152      152              
  Lines       13241    13250       +9     
==========================================
+ Hits        12939    12945       +6     
- Misses        213      215       +2     
- Partials       89       90       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatsuhiro-t
Copy link
Contributor Author

I ran all scripts and fixed typo, and added generated files.

gmlewis
gmlewis approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tatsuhiro-t !
LGTM.

Waiting on CLA check before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2024

@googlebot snap out of it.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2024

@googlebot help

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2024

@google-ospo-team - can you please snap @googlebot out of its stupor?
It has been running 14 hours so far with no progress.
Thank you!

@gmlewis gmlewis merged commit e7a3cc7 into google:master Jan 19, 2024
5 of 7 checks passed
@tatsuhiro-t tatsuhiro-t deleted the add-pullrequestlinks-merged-at branch January 22, 2024 00:51
@gmlewis gmlewis mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MergedAt field to PullRequestLinks
2 participants
@tatsuhiro-t @gmlewis